[Patch] Signature for format=flowed

[Jorge A. Alfaro-Murillo]

Hi,

This makes signatures respect hard-new-lines for people that like
format=flowed.

Best,

[Ted Zlatanov]

On Mon, 13 Oct 2014 12:29:08 -0400 jorge.alfaro-***@yale.edu (Jorge A. Alfaro-Murillo) wrote:

JAA> This makes signatures respect hard-new-lines for people that like
JAA> format=flowed.

That seems reasonable; does `newline' work in all the supported Emacsen?

Ted

[Jorge A. Alfaro-Murillo]

Post by Ted Zlatanov
That seems reasonable; does `newline' work in all the supported Emacsen?

It is used already in message.el in
`message-newline-and-reformat', `message-add-archive-header',
`message-insert-formatted-citation-line',
`message-insert-citation-line' and a couple more places, so I
suppose yes and, more importantly, it will not break anything that
is already broken =)

Best,

[Ted Zlatanov]

Post by Ted Zlatanov
That seems reasonable; does `newline' work in all the supported Emacsen?

JAA> It is used already in message.el in `message-newline-and-reformat',
JAA> `message-add-archive-header',
JAA> `message-insert-formatted-citation-line',
JAA> `message-insert-citation-line' and a couple more places, so I suppose
JAA> yes and, more importantly, it will not break anything that is already
JAA> broken =)

All right, could you resubmit the patch with a proper ChangeLog entry?
It looks OK otherwise.

Ted

[Jorge A. Alfaro-Murillo]

Post by Ted Zlatanov
All right, could you resubmit the patch with a proper ChangeLog
entry? It looks OK otherwise.

Sorry Ted, this is the first time that I send a patch to gnus.
What do I have to do exactly? Is the description that I added to
the patch not enough? I mean:

* lisp/gnus/message.el (message-insert-signature): Change (insert
"\n") for (newline)

Best,

[Ted Zlatanov]

Post by Ted Zlatanov
All right, could you resubmit the patch with a proper ChangeLog
entry? It looks OK otherwise.

JAA> Sorry Ted, this is the first time that I send a patch to gnus. What do
JAA> I have to do exactly? Is the description that I added to the patch not
JAA> enough? I mean:

JAA> * lisp/gnus/message.el (message-insert-signature): Change (insert
JAA> "\n") for (newline)

Look at the existing ChangeLog and add your entry there, then send the
full diff.

I'd also reword, for clarity:

Use `newline' instead of inserting explicit "\n".

...but I don't feel strongly about it, so it's your call :)

Ted

[Jorge A. Alfaro-Murillo]

Post by Ted Zlatanov
Look at the existing ChangeLog and add your entry there, then
send the full diff.

Ok, let me know if this is okay.

Best,

[Ted Zlatanov]

Post by Ted Zlatanov
Look at the existing ChangeLog and add your entry there, then send
the full diff.

JAA> Ok, let me know if this is okay.

It was great; applied. Thank you for the patch.

Ted